Rock paper scissors issue javascript

Well i made rock paper scissors in javascript on codeacademy and im trying to make it so that if your input is not "rock" paper or scissor then it will send you an alert and return back to the prompt however im having an issue with it:

the issue itself is if i type anything in, including rock, paper, or scissor it still does the what is inside the "if" statement, so anyone see what is wrong with the check? and also how would i make it go back and ask the prompt question again until the proper input is typed in, i tried a while loop earlier but it didnt work, but i think it didnt work because the check is done incorrectly

Code:

---

var userChoice = prompt("Do you choose rock, paper or scissors?");


    if(userChoice.toLowerCase() !== ("rock" || "paper" || "scissor")) { 
    alert("Please answer with: rock, paper, or scissor.");
    }

 

var computerChoice = Math.random();
if (computerChoice < 0.34) {
        computerChoice = "rock";
} else if(computerChoice <= 0.67) {
        computerChoice = "paper";
} else {
        computerChoice = "scissors";
} console.log("Computer: " + computerChoice);


var compare = function(choice1, choice2) {
   

   
    if (choice1 === choice2) {
        return userChoice = prompt("Do you choose rock, paper or scissors?");
    }
   
    if(choice1 === "rock") {
        if(choice2 === "scissors") {
            return "rock wins";
        } else {
            return "paper wins";
        }
    }
   
    if(choice1 === "paper") {
        if(choice2 === "rock") {
            return "Paper wins";
        } else {
            return "Scissors wins";
        }
    }
   
    if(choice1 == "scissors")  {
        if(choice2 == "paper") {
            return "Scissors wins";
        } else {
            return "Rock wins";
        }
    }
};


compare(userChoice, computerChoice);

---

Code:

---

("rock" || "paper" || "scissor")

---

doesn't do what you think it does lol

try printing that out

Quote:

---

Originally Posted by packersfan84 [Only registered and activated users can see links. Click Here To Register...]

Code:

---

("rock" || "paper" || "scissor")

---

doesn't do what you think it does lol

try printing that out

---

i resolved that part of the issue :3, by just doing

Code:

---

var userChoice = prompt("Do you choose rock, paper or scissors?");


    if(userChoice.toLowerCase() === ("rock" || "paper" || "scissor")) { 
 
   

 

var computerChoice = Math.random();
if (computerChoice < 0.34) {
        computerChoice = "rock";
} else if(computerChoice <= 0.67) {
        computerChoice = "paper";
} else {
        computerChoice = "scissors";
} console.log("Computer: " + computerChoice);


var compare = function(choice1, choice2) {
   
    var choice1 = choice1.toLowerCase();
    var choice2 = choice2.toLowerCase();
   
    if (choice1 === choice2) {
        return userChoice = prompt("Do you choose rock, paper or scissors?");
    }
   
    if(choice1 === "rock") {
        if(choice2 === "scissors") {
            return "rock wins";
        } else {
            return "paper wins";
        }
    }
   
    if(choice1 === "paper") {
        if(choice2 === "rock") {
            return "Paper wins";
        } else {
            return "Scissors wins";
        }
    }
   
    if(choice1 == "scissors")  {
        if(choice2 == "paper") {
            return "Scissors wins";
        } else {
            return "Rock wins";
        }
    }
};


compare(userChoice, computerChoice);


} else {
    alert("Please answer with: rock, paper, or scissor.");
}

---

but i dont really understand why because doesnt !== mean if it doesnt equal this then do that? or am i misunderstanding that

Quote:

---

Originally Posted by Andrew [Only registered and activated users can see links. Click Here To Register...]

i resolved that part of the issue :3, by just doing

Code:

---

var userChoice = prompt("Do you choose rock, paper or scissors?");


    if(userChoice.toLowerCase() === ("rock" || "paper" || "scissor")) { 
 
   

 

var computerChoice = Math.random();
if (computerChoice < 0.34) {
        computerChoice = "rock";
} else if(computerChoice <= 0.67) {
        computerChoice = "paper";
} else {
        computerChoice = "scissors";
} console.log("Computer: " + computerChoice);


var compare = function(choice1, choice2) {
   
    var choice1 = choice1.toLowerCase();
    var choice2 = choice2.toLowerCase();
   
    if (choice1 === choice2) {
        return userChoice = prompt("Do you choose rock, paper or scissors?");
    }
   
    if(choice1 === "rock") {
        if(choice2 === "scissors") {
            return "rock wins";
        } else {
            return "paper wins";
        }
    }
   
    if(choice1 === "paper") {
        if(choice2 === "rock") {
            return "Paper wins";
        } else {
            return "Scissors wins";
        }
    }
   
    if(choice1 == "scissors")  {
        if(choice2 == "paper") {
            return "Scissors wins";
        } else {
            return "Rock wins";
        }
    }
};


compare(userChoice, computerChoice);


} else {
    alert("Please answer with: rock, paper, or scissor.");
}

---

but i dont really understand why because doesnt !== mean if it doesnt equal this then do that? or am i misunderstanding that

---

[Only registered and activated users can see links. Click Here To Register...]

Quote:

---

Originally Posted by Valiant [Only registered and activated users can see links. Click Here To Register...]

[Only registered and activated users can see links. Click Here To Register...]

---

Posting a link w/o any explanation of what he's done wrong isn't very nice, considering you linked him to the completely wrong place anyway.

Your problem here is this expression: ("rock" || "paper" || "scissor"). Think about it for a minute, you are comparing the result of userChoice.toLowerCase() to the evaluation of the former expression. I'm not sure what you think that evaluates to, but here's an example:

Code:

---

console.log("what"); // "what"
console.log("what" == true); // true
console.log("what" === true); // type and value comparison, false
console.log(("what" || "what2")); // true

---

You can see that "what" == true because a non-empty string in JavaScript is a truthy value. You want to be checking the user input to each individual choice before entering your routine.

See more about it here: [Only registered and activated users can see links. Click Here To Register...]